Hello Bastien,

Same comments about preprocessor directive indentation,
GNU style, and the autoconf/shell variables.

> diff --git a/lib/explicit_bzero.c b/lib/explicit_bzero.c
> index 862855421..b355f9bdf 100644
> --- a/lib/explicit_bzero.c
> +++ b/lib/explicit_bzero.c
> @@ -32,6 +32,11 @@
>  
>  #include <string.h>
>  
> +#if defined WIN32 && defined HAVE_SECUREZEROMEMORY

The preprocessor condition for the Windows API is not
  defined WIN32
but
  defined _WIN32 && !defined __CYGWIN__

Also, since this function is present on Windows XP and newer
https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/aa366877(v=vs.85)

and gnulib does not target older versions of Windows, you can
probably just omit the HAVE_SECUREZEROMEMORY test.

Bruno


Reply via email to