> + * tests/test-canonicalize.c: Protect the inclusion of null-ptr.h
> + with the same guard as that used to protect usage of the null_ptr
> + function
The patch is OK.
However, I would appreciate if you don't call a warning a "build failure"
or an "error".
Reasons:
1. Adding -Werror to the CFLAGS is under the responsibility of the package
and/or person who builds the package. Gnulib does not add -Werror.
2. For this reason, someone who builds the package has a much easier
fix/workaround -- namely, just remove '-Werror' in one or two places in
the Makefiles -- than when there is e.g. a syntax error or a link error.
3. Gnulib does not and can not guarantee warning-free compilation, because
there are so many platforms, so many compiler warning options, and
sometimes even false positives among the warnings.
All that Gnulib guarantees is an error-free compilation *without* -Werror.
Bruno
