On 1/18/20 5:14 AM, Bruno Haible wrote:
1) I moved the AC_PROG_CC override from 00gnulib.m4 to ~~gnulib.m4
Although I haven't tried the patch, surely the name '~~gnulib.m4' causes problems. I imagine some programs use '~' for other naming conventions (e.g., for deleted files). On systems that use alphabetic characters first for collating, 'ls' and 'echo *' don't put the '~~' file last anyway; this happened on my Ubuntu 18.04.3 machine in the en_US.utf8 locale. On systems with GNU ls, the leading '~' causes ls to quote the file name and to put spaces in front of other file names in the same directory, which is an annoyance (albeit a necessary one to warn users of the problem with cutting and pasting that file name). And if there is a user whose name happens to be '~gnulib.m4' (admittedly unlikely, but POSIX allows this as an extension), the string ~~gnulib.m4 will expand to that user's home directory in the shell.
For all these reasons I suggest renaming the file to zzgnulib.m4.
