* Tim Rühsen <tim.rueh...@gmx.de> [181014 15:07]: > On 13.10.18 23:19, Darshit Shah wrote: > > Well, I don't think there will be a Python 4 for a very long time. The major > > version number changes only for a large backwards incompatibility. It's > > taken > > them ~10 years and people still not on Python 3. > > > > Anyways, I don't think this will break even with v4. Since the check is only > > for ensuring the minimum version number. > > I was referring to > if not PYTHON3 or sys.version_info[1] < 7: > > PYTHON3 is true for any python version except 2 (maybe rename it to > PYTHON2 and inverse the logic ?). > > But the 'or sys.version_info[1] < 7' would be true for python 4.0, so it > would print "Python version must be atleast 2.7. Exiting.". > That is a stupid typo that I left behind in the code. As Gisle pointed out in the other email, it should be "and" > > > > > * Tim Rühsen <tim.rueh...@gmx.de> [181013 23:05]: > >> On 13.10.18 21:28, Darshit Shah wrote: > >>> gnulib-tool.py will currently crash immediately on start if the underlying > >>> Python version is 2.6 or lower. The immediate crash that is seen occurs > >>> during > >>> the check for the Python version. The check uses a syntax which was only > >>> introduced in 2.7. I haven't checked, but I believe that the rest of the > >>> script > >>> also uses 2.7+ syntax. Hence, I have also added a check to the script to > >>> exit > >>> out if the version of Python being used is less than 2.7. > >> > >> Thanks so much ! > >> > >> But could make this a bit more future-proof. I was just thinking that > >> python version 4.0 would break your checks. > >> > >> Regards, Tim > >> > > > > > > > > >
-- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
signature.asc
Description: PGP signature
