On 03/05/2018 01:50 PM, Reuben Thomas wrote:
Is there some reason that the unused parameter is not suitably decorated for gcc?
I expect it is because nobody has gotten around to it. I installed the attached.
>From 746fe7d6c56f87e9f51679acf2f7b8464520baac Mon Sep 17 00:00:00 2001 From: Paul Eggert <egg...@cs.ucla.edu> Date: Mon, 5 Mar 2018 15:30:56 -0800 Subject: [PATCH] binary-io: pacify gcc -Wunused-parameter Problem reported by Reuben Thomas in: https://lists.gnu.org/r/bug-gnulib/2018-03/msg00005.html * lib/binary-io.h (__gl_setmode, __gl_setmode_check): Use _GL_UNUSED where appropriate. --- ChangeLog | 6 ++++++ lib/binary-io.h | 6 ++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index beb835670..8f372dfb9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2018-03-05 Paul Eggert <egg...@cs.ucla.edu> + binary-io: pacify gcc -Wunused-parameter + Problem reported by Reuben Thomas in: + https://lists.gnu.org/r/bug-gnulib/2018-03/msg00005.html + * lib/binary-io.h (__gl_setmode, __gl_setmode_check): + Use _GL_UNUSED where appropriate. + fflush: adjust to glibc 2.28 libio.h removal Problem reported by Daniel P. Berrangé in: https://lists.gnu.org/r/bug-gnulib/2018-03/msg00000.html diff --git a/lib/binary-io.h b/lib/binary-io.h index cce1301d5..1f21fc051 100644 --- a/lib/binary-io.h +++ b/lib/binary-io.h @@ -47,10 +47,8 @@ _GL_INLINE_HEADER_BEGIN /* Use a function rather than a macro, to avoid gcc warnings "warning: statement with no effect". */ BINARY_IO_INLINE int -__gl_setmode (int fd, int mode) +__gl_setmode (int fd _GL_UNUSED, int mode _GL_UNUSED) { - (void) fd; - (void) mode; return O_BINARY; } #endif @@ -59,7 +57,7 @@ __gl_setmode (int fd, int mode) extern int __gl_setmode_check (int); #else BINARY_IO_INLINE int -__gl_setmode_check (int fd) { return 0; } +__gl_setmode_check (int fd _GL_UNUSED) { return 0; } #endif /* Set FD's mode to MODE, which should be either O_TEXT or O_BINARY. -- 2.14.3
