On 30/08/17 22:14, Pádraig Brady wrote: > On 30/08/17 22:05, Paul Eggert wrote: >> Pádraig Brady wrote: >>> I notice the new test-fts in gnulib was taking a while, >>> and it creates 128K files/dirs on a quick look. >> >> It creates 65,000 directories and 4 files. On my old desktop (no flash, just >> hard disk, ext4, Fedora 26) it takes 17 s real time. If this is too much, I >> suppose we can mark the test as expensive, or remove it. > > Yes that would be useful to mark as expensive > (I didn't know one could mark gnulib tests as such) > > As well as the 17s, I see: > > $ mkdir t && cd t > $ seq 65535 | xargs mkdir > $ du -hs . > 285M
The attached gnulib patch seems to exclude the test as coreutils uses --with-tests with gnulib-tool cheers, Pádraig
>From a17c2cc8bf457f35789f74aa771cd15ec71c7253 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= <p...@draigbrady.com> Date: Wed, 30 Aug 2017 22:32:23 -0700 Subject: [PATCH] fts-tests: tag as a longrunning-test so not included by default * modules/fts-tests: This test takes about 20s on current systems, and uses about 285M of space. --- ChangeLog | 6 ++++++ modules/fts-tests | 3 +++ 2 files changed, 9 insertions(+) diff --git a/ChangeLog b/ChangeLog index 0b3c06a..24429da 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2017-08-30 Pádraig Brady <p...@draigbrady.com> + fts-tests: tag as a longrunning-test so not included by default + * modules/fts-tests: This test takes about 20s on current systems, + and uses about 285M of space. + +2017-08-30 Pádraig Brady <p...@draigbrady.com> + renameat2: fix compilation on alpine linux * m4/renameat.m4: Check for <linux/fs.h> presence. * lib/renameat2.h: Only include <linux/fs.h> if present. diff --git a/modules/fts-tests b/modules/fts-tests index 1651290..1a9dce0 100644 --- a/modules/fts-tests +++ b/modules/fts-tests @@ -1,3 +1,6 @@ +Status: +longrunning-test + Files: tests/test-fts.c -- 2.9.3
