Bruno Haible wrote:

Is it intentional that regex-internal.h now uses __builtin_expect
unconditionally, yet the module 'regex' does not depend on 'builtin-expect'?

No, and thanks for catching that typo. I installed the attached.
>From 56687b30218a291dbb8e3d7eb712183e7ed09f43 Mon Sep 17 00:00:00 2001
From: Paul Eggert <egg...@cs.ucla.edu>
Date: Fri, 16 Dec 2016 16:32:04 -0800
Subject: [PATCH] regex: fix dependency

Problem reported by Bruno Haible in:
http://lists.gnu.org/archive/html/bug-gnulib/2016-12/msg00073.html
* modules/regex: Depend on builtin-expect.
---
 ChangeLog     | 5 +++++
 modules/regex | 1 +
 2 files changed, 6 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 451e1d5..aba7199 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2016-12-16  Paul Eggert  <egg...@cs.ucla.edu>
 
+	regex: fix dependency
+	Problem reported by Bruno Haible in:
+	http://lists.gnu.org/archive/html/bug-gnulib/2016-12/msg00073.html
+	* modules/regex: Depend on builtin-expect.
+
 	builtin-expect: new module
 	Fix fnmatch to use it.
 	Problem reported for z/OS by Daniel Richard G.
diff --git a/modules/regex b/modules/regex
index e1c9b58..2d93c5e 100644
--- a/modules/regex
+++ b/modules/regex
@@ -17,6 +17,7 @@ extensions
 ssize_t
 alloca-opt      [test $ac_use_included_regex = yes]
 btowc           [test $ac_use_included_regex = yes]
+builtin-expect  [test $ac_use_included_regex = yes]
 gettext-h       [test $ac_use_included_regex = yes]
 intprops        [test $ac_use_included_regex = yes]
 lock      [test "$ac_cv_gnu_library_2_1:$ac_use_included_regex" = no:yes]
-- 
2.7.4

Reply via email to