On Saturday, 3 September 2016 20:47:15 CEST Jim Meyering wrote: > On Thu, Aug 18, 2016 at 6:18 AM, Pino Toscano <ptosc...@redhat.com> wrote: > > as discussed in [1], this series adds a new getprogname module. > > All it does is providing a getprogname function, much like what is > > found on e.g. *BSD systems, and using it in gnulib instead of progname. > > Also, using it explicitly by modules avoids gnulib users the need of > > either use the progname module (GPL), or to provide program_name (and > > call set_program_name manually, which is not always doable). > > > > Caveat: the progname is left as it is, so set_program_name will still > > affect program_name but not what error will use. > > > > (Please note it's my first big patch to gnulib, so bear with me for > > anything wrong/missing.) > > > > [1] http://lists.gnu.org/archive/html/bug-gnulib/2016-03/msg00048.html > > Thanks for your patience.
Thanks for the review, Jim. > I amended the first commit to do this: > > * MODULES.html.sh (Misc): Add getprogname. > > Two things were mistakenly removed. I have restored them: > > * lib/argmatch.c: Do not elide this comment: > > /* > * Based on "getversion.c" by David MacKenzie <d...@gnu.ai.mit.edu> > */ > > * modules/argmatch (Depends-on): Do not remove getprogname. Sorry for the small issues in the patches -- your amendments look fine to me. Another thing: should some deprecation warning/note be added regarding the progname module? Is NEWS the proper place for them? Attached there is a small documentation addendum. > I'm prepared to push the attached, but will wait for your ack. ACK. Thanks, -- Pino Toscano
From 64ea76d0aee46e81f6dab1f266301da9cef3ba07 Mon Sep 17 00:00:00 2001
From: Pino Toscano <ptosc...@redhat.com>
Date: Mon, 5 Sep 2016 16:26:27 +0200
Subject: [PATCH] Deprecate the 'progname' module
* NEWS: Document the deprecation of the 'progname' module.
---
ChangeLog | 4 ++++
NEWS | 8 ++++++++
2 files changed, 12 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index ba3e048..fb551f7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2016-09-05 Pino Toscano <ptosc...@redhat.com>
+
+ * NEWS: Document the deprecation of the 'progname' module.
+
2016-09-02 Jim Meyering <meyer...@fb.com>
manywarnings: add -fno-common
diff --git a/NEWS b/NEWS
index e33d350..1758d22 100644
--- a/NEWS
+++ b/NEWS
@@ -42,6 +42,14 @@ User visible incompatible changes
Date Modules Changes
+2016-09-05 progname This module is deprecated. Please switch to the
+ 'getprogname' module and its getprogname()
+ function to know the name of the current program,
+ and there is no more need to export a
+ 'const char *program_name' variable.
+ Currently there is no replacement for
+ set_program_name().
+
2016-08-17 stdbool This no longer supports _Bool for C++.
Programs intended to be portable to C++
compilers should use plain 'bool' instead.
--
2.7.4
signature.asc
Description: This is a digitally signed message part.
