On 3/29/2016 9:10 PM, Paul Eggert wrote:
On 03/29/2016 07:00 AM, Ken Brown wrote:
- name" problems on Cygwin.
+ name" problems on newlib systems..
No double '..'; and maybe the comment could say "newlib systems,
including Cygwin", since that is our most common newlib system.
Otherwise, I'm okay with the change.
Could someone install this change (assuming there's no objection)?
The ifdef says 'defined __CYGWIN__' and this matches the comment. All
other Gnulib comments talk about Cygwin not newlib, and it'd be
confusing to make a special distinction only here.
I suppose that if this code is newlib-specific, not Cygwin-specific, it
should use 'defined __NEWLIB__' and then the comment should be changed
as you suggest.
I already did change it to 'defined __NEWLIB__' in the patch that I
suggested
(http://lists.gnu.org/archive/html/bug-gnulib/2016-03/msg00065.html).
It wasn't just a change in the comment.
But in that case, what other uses of __CYGWIN__ should
be changed to __NEWLIB__? There are quite a few uses of __CYGWIN__, and
I don't know which of them apply just to Cygwin and which apply to
newlib in general.
Yes, I thought of that too. Someone would have to look at each of them
and decide if they apply to newlib in general. I would be willing to
take a shot at this. But I would do it as I have time, not necessarily
all at once. Would you rather wait until I've finished this and then
install all the changes at once?
Ken
