In similar vein, for lib/vasnprintf.c...
From d36b1b0fc4b40b9346e4d8d4b46ed8976a59352b Mon Sep 17 00:00:00 2001 From: Thien-Thi Nguyen <t...@gnu.org> Date: Sun, 31 Aug 2014 10:27:36 +0200 Subject: [PATCH] vasnprintf: Avoid signed/unsigned comparison warning.
* lib/vasnprintf.c (VASNPRINTF): To calculate padding,
compare end addr of generated string w/ maximum end addr.
---
ChangeLog | 6 ++++++
lib/vasnprintf.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index c48ca83..c466e87 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2014-08-31 Thien-Thi Nguyen <t...@gnu.org> (tiny change)
+
+ vasnprintf: Avoid signed/unsigned comparison warning.
+ * lib/vasnprintf.c (VASNPRINTF): To calculate padding,
+ compare end addr of generated string w/ maximum end addr.
+
2013-08-30 Mats Erik Andersson <g...@gisladisker.se> (tiny change)
parse-datetime: Avoid pointer difference.
diff --git a/lib/vasnprintf.c b/lib/vasnprintf.c
index f2ccc1c..6ca47eb 100644
--- a/lib/vasnprintf.c
+++ b/lib/vasnprintf.c
@@ -3356,7 +3356,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
}
/* The generated string now extends from tmp to p, with the
zero padding insertion point being at pad_ptr. */
- if (has_width && p - tmp < width)
+ if (has_width && p < tmp + width)
{
size_t pad = width - (p - tmp);
DCHAR_T *end = p + pad;
--
1.9.1
--
Thien-Thi Nguyen
GPG key: 4C807502
(if you're human and you know it)
read my lisp: (responsep (questions 'technical)
(not (via 'mailing-list)))
=> nil
signature.asc
Description: PGP signature
