On 10/19/2013 09:03 PM, Jim Meyering wrote:
> With very recent gcc and all warnings enabled for grep's subset of
> gnulib, I was seeing warnings about functions that deserve pure, const
> and gnu_printf attributes.
> 

> From 88e5b4d4641f294d8f824d770c9c55a1abe49768 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyer...@fb.com>
> Date: Sat, 12 Oct 2013 19:28:40 -0700
> Subject: [PATCH 2/2] error: make the module depend on vfprintf-posix
> 
> * modules/error (Depends-on): Add vfprintf-posix, since error
> calls vfprintf unconditionally, via error_tail.

This patch breaks at least libvirt:

autoreconf: running: aclocal -I m4 --force -I m4
missing file gnulib/tests/vasnprintf.c
configure.ac:135: error: expected source file, required through
AC_LIBSOURCES, not found
m4/gnulib-comp.m4:518: gl_INIT is expanded from...
configure.ac:135: the top level
autom4te: /usr/bin/m4 failed with exit status: 1

I _think_ the problem is that tests must NOT depend on *printf-posix,
but I'm still trying to investigate how to fix it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to