On 09/25/13 11:01, Eric Blake wrote: > I don't know if this is a case of diffutils being too aggressive about > the warnings it uses on gnulib files
Yes, that sounds good enough. I pushed this into diffutils: >From 1d69c1591812101e2dffa64c45e2f1c3c901fadc Mon Sep 17 00:00:00 2001 From: Paul Eggert <egg...@cs.ucla.edu> Date: Thu, 26 Sep 2013 12:20:00 -0700 Subject: [PATCH] build: omit -Wsuggest-attribute=pure for lib * configure.ac (WARN_CFLAGS): Omit -Wsuggest-attribute=pure when compiling the lib subdirectory. Reported for Fedora 19 by Eric Blake in <http://bugs.gnu.org/15463>. --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 90bebc9..f7efcb1 100644 --- a/configure.ac +++ b/configure.ac @@ -123,6 +123,7 @@ if test "$gl_gcc_warnings" = yes; then nw="$nw -Wunused-macros" nw="$nw -Wmissing-prototypes" nw="$nw -Wold-style-definition" + nw="$nw -Wsuggest-attribute=pure" gl_MANYWARN_COMPLEMENT([GNULIB_WARN_CFLAGS], [$WARN_CFLAGS], [$nw]) AC_SUBST([GNULIB_WARN_CFLAGS]) fi -- 1.8.3.1
