On 04/23/2013 11:16 AM, Dmitry V. Levin wrote:
> On Tue, Apr 23, 2013 at 10:54:03AM +0100, Pádraig Brady wrote:
>> I'm still thinking the gnulib patch should be applied though,
> 
> Since the regression in glibc was detected by this gnulib test,
> I'm not sure ignoring all EAI_SYSTEM errors would be a good idea.

That's a happy accident.
gnulib tests should not be worrying about glibc internals IMHO
I notice the proposed glibc patch above has no associated tests?
I presume there are glibc units tests that should be updated?

>> as you wouldn't want to indicate a gnulib issue if you ran
>> out of file descriptors on the system for example?
> 
> Lets skip the test in case of EAI_SYSTEM && (EMFILE || ENFILE) then.

There are many other things that could trigger here.

thanks,
Pádraig.

Reply via email to