Paul Eggert wrote: > On 09/25/2012 06:19 AM, Nikos Mavrogiannopoulos wrote: > >> Would it be possible to relicense hash-pjw under LGPLv2+ or v3+? > > Makes sense to me, since the same code is distributed elsewhere > in gnulib under LGPLv2+ -- see localename.c. Jim?
Yes, switching it to LGPLv2+ is fine with me. >> Also would it be possible to have a version that works with >> non-null terminated strings? (patch attached). > > Sounds easy, perhaps in a separate file. > >> A question on this function is why do you use char *s to describe >> input and not unsigned char*? Given that h is unsigned anyway I don't >> see the purpose for having s signed. > > But 'char' might not be signed. And here it doesn't matter whether it's > signed, so it's cleaner to not say either way. > > The basic idea, originally, is that 'char' was supposed to > be either signed char or unsigned char, whichever was faster, so > the C tradition is to use 'char' when we don't care, so to speak.
