On 09/25/2012 06:27 AM, Akim Demaille wrote:
> Recent changes introduce -Wundef warnings in config.h.  The
> appended proposal eliminates them.
> 

> -#if __GNUC__ ? __GNUC_STDC_INLINE__ : 199901L <= __STDC_VERSION__
> +#if (__GNUC__ \

Even though gcc's -Wundef will never warn about __GNUC__ being
undefined, it seems like you should also be checking that __GNUC__ is
defined for the sake of non-gcc compilers, if we accept this approach.

At any rate, while most of gnulib doesn't care about -Wundef, I can
agree to the concept of having config.h be -Wundef clean, so I'm okay
with this patch if Paul is.

-- 
Eric Blake   ebl...@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to