On 08/02/2012 10:53 AM, Stefano Lattarini wrote:
> * modules/gnumakefile [Makefile.am]: The makefiles generated by
> Automake-NG always contain a definition of VPATH, even in non-VPATH
> builds (its value being simply '.' in that case).  So, in the
> 'clean-GNUmakefile' rule, to determine whether running under a
> VPATH setup, compare '$(srcdir)' to '.' rather than checking whether
> '$(VPATH)' expands to the empty string.
> ---

That fixes things with automake-ng, but what about with existing automake?

>  clean-GNUmakefile:
> -     test x'$(VPATH)' != x && rm -f $(top_builddir)/GNUmakefile || :
> +     test '$(srcdir)' = . || rm -f $(top_builddir)/GNUmakefile

That is, shouldn't this really be:

case '$(srcdir)' in
  .|'') ;;
  *) rm -f $(top_builddir)/GNUmakefile ;;
esac

-- 
Eric Blake   [email protected]    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to