Hi Jim!
Le 6 juil. 2012 à 11:43, Jim Meyering a écrit :
> Thanks for the patch.
>
> Those all look like improvements, but I'd prefer that
> you change the name s/stderr/warn/: "stderr" is not normally
> used as a verb.
OK. I avoided "warn" because I felt it would be valid
for it to include a "warning: " prefix.
> Also, I am in the habit of writing e.g.,
>
> warn this does not need quotes
>
> With your implementation, that would print the expansion of:
>
> $me: this
> $me: does
> $me: not
> $me: need
> $me: quotes
>
> Something like the warn_ function in tests/init.sh (but without the
> stderr_fileno_ bit) may do what we want: it's received pretty much testing.
It is also very useful to have a single command that issues
several lines. This is the case here for instance:
test $found_aux_dir = yes \
|| die "expected line not found in configure.ac. Add the following:" \
" AC_CONFIG_AUX_DIR([$build_aux])"
So what should I do? (I like to see the messages fontified, so I
always quote them).
