Akim Demaille wrote:
> Hi friends,
Hi Akim,
> I just installed this.
>
> Subject: [PATCH] do-release-commit-and-tag: fix typo
In the future, please post a heads-up patch before you push,
in case someone sees a problem.
...
> --- a/build-aux/do-release-commit-and-tag
> +++ b/build-aux/do-release-commit-and-tag
...
> @@ -130,7 +130,7 @@ pkg=$(sed -n 's/^PACKAGE = \(.*\)/\1/p' "$Makefile") \
> || die "failed to determine package name from $Makefile"
>
> # simple check: no question marks on line 3 of NEWS
> -test "$(sed -n 3p NEWS)" = "$noteworthy_stub" \
> +test "$(sed -n 3p NEWS)" != "$noteworthy_stub" \
> || die 'line 3 of NEWS looks fishy!'
First, that's sort of like a double negative.
This is a more readable equivalent of what you've committed:
test "$(sed -n 3p NEWS)" = "$noteworthy_stub" \
&& die 'line 3 of NEWS looks fishy!'
More importantly, won't this script now fail for every
package I maintain, since they all have this on line 3 of NEWS?
* Noteworthy changes in release ?.? (????-??-??) [?]
