Paul Eggert wrote:
> On 11/29/11 09:35, Jim Meyering wrote:
>> + gl_WARN_ADD([-Wno-unsuffixed-float-constants])
>
> How about if we remove -Wunsuffixed-float-constants from
> manywarnings.m4? In practice it typically causes more
> trouble than it cures (the above-quoted gzip patch is
> one example, but I've run into it elsewhere).
Good idea.
> While we're on the subject of manywarnings.m4, can we also
> remove -Wdouble-promotion and -Wformat-zero-length? They
> also seem to be more suited for special- rather than
> general-purpose code.
Coreutils' gnulib lib/* files had only one
"-Wdouble-promotion"-triggered warning:
# FIXME: it may be easy to remove this, since it affects only one file:
# the snprintf call at ftoastr.c:132.
nw="$nw -Wdouble-promotion"
So maybe it's not a burden to most projects.
I haven't investigated the ftoastr.c issue.
Have you found code that triggers a -Wformat-zero-length warning
yet that doesn't seem worth adjusting?
