Hi Simon, > I understand that gnulib's code isn't clean against -Wundef in general, > however I believe code that gnulib puts into config.h should meet a > higher standard
OK. > +2011-11-21 Simon Josefsson <si...@josefsson.org> > + > + * m4/gnulib-common.m4 (_Noreturn): Check that _MSC_VER is defined > + before using it, in code that ends up config.h. sed -e 's/ends up/ends up in/' > diff --git a/m4/gnulib-common.m4 b/m4/gnulib-common.m4 > index 7d83299..8621dec 100644 > --- a/m4/gnulib-common.m4 > +++ b/m4/gnulib-common.m4 > @@ -18,7 +18,7 @@ AC_DEFUN([gl_COMMON_BODY], [ > # if (3 <= __GNUC__ || (__GNUC__ == 2 && 8 <= __GNUC_MINOR__) \ > || 0x5110 <= __SUNPRO_C) > # define _Noreturn __attribute__ ((__noreturn__)) > -# elif 1200 <= _MSC_VER > +# elif defined _MSC_VER && 1200 <= _MSC_VER > # define _Noreturn __declspec (noreturn) > # else > # define _Noreturn Looks good. Fine with me. Bruno -- In memoriam Ricardo Flores Magón <http://en.wikipedia.org/wiki/Ricardo_Flores_Magón>
