Re: [PATCH] parse-datetime: accept ISO 8601 date and time rep with "T" separator

[Jim Meyering]

Pádraig Brady wrote:
> On 08/31/2011 03:25 PM, Jim Meyering wrote:
>
>> diff --git a/lib/parse-datetime.y b/lib/parse-datetime.y
>
>> +iso_8601_time:
>> +    tUNUMBER zone_offset
>> +      {
>> +        set_hhmmss (pc, $1.value, 0, 0, 0);
>> +    pc->meridian = MER24;
>
> There is a tab introduced above.

Thanks!
There were some in largefile.m4, too.
I'm fixing both with this:

>From f02585c1b0257f35aab61aae924f3f91ff7439e0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyer...@redhat.com>
Date: Wed, 31 Aug 2011 17:15:35 +0200
Subject: [PATCH] maint: indent with spaces, not TABs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

I need to get in the habit of running gnulib's "make check".
Both of these would have been caught.
* m4/largefile.m4: Indent with spaces, not TABs.
* lib/parse-datetime.y (iso_8601_time): Likewise.
Spotted by Pádraig Brady.
---
 ChangeLog            |    7 +++++++
 lib/parse-datetime.y |    2 +-
 m4/largefile.m4      |   20 ++++++++++----------
 3 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2c86304..004d610 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2011-08-31  Jim Meyering  <meyer...@redhat.com>

+       maint: indent with spaces, not TABs
+       I need to get in the habit of running gnulib's "make check".
+       Both of these would have been caught.
+       * m4/largefile.m4: Indent with spaces, not TABs.
+       * lib/parse-datetime.y (iso_8601_time): Likewise.
+       Spotted by Pádraig Brady.
+
        test-parse-datetime.c: accommodate a relatively strict gcc warning
        * tests/test-parse-datetime.c (gmt_offset): Declare function "static",
        to avoid a warning from gcc's -Werror=missing-declarations.
diff --git a/lib/parse-datetime.y b/lib/parse-datetime.y
index 027f797..33ef01a 100644
--- a/lib/parse-datetime.y
+++ b/lib/parse-datetime.y
@@ -381,7 +381,7 @@ iso_8601_time:
     tUNUMBER zone_offset
       {
         set_hhmmss (pc, $1.value, 0, 0, 0);
-       pc->meridian = MER24;
+        pc->meridian = MER24;
       }
   | tUNUMBER ':' tUNUMBER o_zone_offset
       {
diff --git a/m4/largefile.m4 b/m4/largefile.m4
index 6986244..d83fea1 100644
--- a/m4/largefile.m4
+++ b/m4/largefile.m4
@@ -19,8 +19,8 @@ m4_define([_AC_SYS_LARGEFILE_TEST_INCLUDES],
     incorrectly reject 9223372036854775807.  */
 @%:@define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
   int off_t_is_large[[(LARGE_OFF_T % 2147483629 == 721
-                      && LARGE_OFF_T % 2147483647 == 1)
-                     ? 1 : -1]];[]dnl
+                       && LARGE_OFF_T % 2147483647 == 1)
+                      ? 1 : -1]];[]dnl
 ])


@@ -58,7 +58,7 @@ rm -rf conftest*[]dnl
 # http://www.unix-systems.org/version2/whatsnew/lfs20mar.html
 AC_DEFUN([AC_SYS_LARGEFILE],
 [AC_ARG_ENABLE(largefile,
-              [  --disable-largefile     omit support for large files])
+               [  --disable-largefile     omit support for large files])
 if test "$enable_largefile" != no; then

   AC_CACHE_CHECK([for special C compiler options needed for large files],
@@ -67,13 +67,13 @@ if test "$enable_largefile" != no; then
      if test "$GCC" != yes; then
        ac_save_CC=$CC
        while :; do
-        # IRIX 6.2 and later do not support large files by default,
-        # so use the C compiler's -n32 option if that helps.
-        AC_LANG_CONFTEST([AC_LANG_PROGRAM([_AC_SYS_LARGEFILE_TEST_INCLUDES])])
-        AC_COMPILE_IFELSE([], [break])
-        CC="$CC -n32"
-        AC_COMPILE_IFELSE([], [ac_cv_sys_largefile_CC=' -n32'; break])
-        break
+         # IRIX 6.2 and later do not support large files by default,
+         # so use the C compiler's -n32 option if that helps.
+         AC_LANG_CONFTEST([AC_LANG_PROGRAM([_AC_SYS_LARGEFILE_TEST_INCLUDES])])
+         AC_COMPILE_IFELSE([], [break])
+         CC="$CC -n32"
+         AC_COMPILE_IFELSE([], [ac_cv_sys_largefile_CC=' -n32'; break])
+         break
        done
        CC=$ac_save_CC
        rm -f conftest.$ac_ext
--
1.7.7.rc0.362.g5a14