Stefano Lattarini wrote: > Hi Eric. Hope you don't mind hearing a minor nit ... ... >> - AS_VAR_SET([gl_next_header], ['<'gl_HEADER_NAME'>']) >> + AS_VAR_SET(gl_next_header, ['<'gl_HEADER_NAME'>']) >> > IMHO you should add a comment here explaining why you are underquoting > (and thus implicitly stating that such underquoting is deliberate, not > a mistake); as in e.g.: > > ... > if test $gl_cv_have_include_next = yes; then > dnl Autoconf 2.59 requires us to underquote here. > AS_VAR_SET(gl_next_header, ['<'gl_HEADER_NAME'>']) > ... > > And similarly for the other usages.
I too was surprised not to see comments. I'd go even further and suggest to add a FIXME comment, so we'll know to revert this change once autoconf-2.59 is no longer supported.
