On 06/02/2011 04:15 PM, Bruno Haible wrote: > Eric Blake wrote on 2011-04-08: >> * modules/pipe2 (Depends-on): Add nonblocking. >> * lib/pipe2.c (pipe2) [WIN32]: Add O_NONBLOCK support. >> * tests/test-pipe2.c (is_nonblocking): Adjust test accordingly. > > This dependency is not warranted and causes trouble in gettext. > > It's not warranted, because if someone calls pipe2() without the O_NONBLOCK > flag, no non-blocking support is needed in stdio.
That is, pipe2 is useful enough in isolation, but not full-featured unless nonblocking is also in use. Fair enough, and nice patch. Before you apply, though, please also update docs/glibc-functions/pipe2.texi to document which modules are needed. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
