On 05/12/2011 08:52 AM, Jim Meyering wrote: > Hi Eric, > > This test would fail for me when I made iwhd use the latest from gnulib: > > FAIL: test-fclose (exit: 134) > ============================= > test-fclose.c:77: assertion failed > > It looks pretty obvious, but I'll wait for your ACK, just in case.
NACK. The whole point of this test is to expose the glibc bug. fclose() is _required_ to rewind seekable input streams back to the point of the last byte returned by fgetc(). That is, even though fgetc() advanced the position to EOF, the fclose() must undo that advance. More likely, this means all the recent flurry in lib/fclose.c has somehow introduced a regression :( -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
