Paul Eggert wrote: > +#include <config.h> > + > +#include "careadlinkat.h" > + > +#include "allocator.h" > + > +#include <errno.h> > +#include <limits.h> > +#include <stdlib.h> > +#include <string.h> > +#include <unistd.h>
How about using the common gnulib style to mention system includes before gnulib includes? Here's a proposed patch. I verified that it causes no regression, even if the obsolete 'free' module is in use and it defines free to rpl_free. --- lib/careadlinkat.c.orig Sat Apr 9 18:48:48 2011 +++ lib/careadlinkat.c Sat Apr 9 18:46:51 2011 @@ -22,8 +22,6 @@ #include "careadlinkat.h" -#include "allocator.h" - #include <errno.h> #include <limits.h> #include <string.h> @@ -38,6 +36,8 @@ # define SSIZE_MAX ((ssize_t) (SIZE_MAX / 2)) #endif +#include "allocator.h" + #if ! HAVE_READLINKAT /* Ignore FD. Get the symbolic link value of FILENAME and put it into BUFFER, with size BUFFER_SIZE. This function acts like readlink -- In memoriam Georg Elser <http://en.wikipedia.org/wiki/Georg_Elser>