On 03/11/2011 02:32 AM, Jim Meyering wrote: > Pádraig Brady wrote: >> A recent change to dd in coreutils triggered this issue, >> which is avoided with the attached. > >> sc_unmarked_diagnostics: >> @grep -nE \ >> '\<error *\([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT)) \ >> - | grep -v '_''(' && \ >> + | grep -Ev '(_|ngettext )\(' && \
Don't we recommend the use of N_() rather than spelling out ngettext ()? > > Then wondered if we should be more permissive in what we filter out, > perhaps by allowing 0 or more spaces between ngettext and the following "(": > > | grep -Ev '(_|ngettext *)\(' && \ If we're going to look for raw ngettext, why not also look for raw gettext, or even d?c?n?gettext? -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature