On 01/11/2011 12:08 PM, Paul Eggert wrote: > On 01/11/11 11:03, Eric Blake wrote: >> But you should still drop the xmalloc dependency from the module >> description. > > Hmm, sorry, I guess I should have mentioned that I looked for that, > and couldn't find the dependency. The only modules that mention > lib/openat-proc.c are fdopendir and openat, and neither module > depends on xmalloc. I think this is a dependency bug, and that > my proposed patch fixes it by removing the need for the dependency.
Hmm, it's an indirect dependency, but it's definitely being pulled in:
$ ./gnulib-tool --with-tests --test openat
Module list with included dependencies (indented):
arg-nonnull
binary-io
binary-io-tests
c++defs
chdir-long
chown
chown-tests
cloexec
cloexec-tests
close
close-hook
d-ino
dirent
dirent-tests
dirfd
dirname-lgpl
double-slash-root
dup2
dup2-tests
errno
errno-tests
error
exitfail
extensions
fchdir
fchdir-tests
fclose
fcntl
fcntl-h
fcntl-h-tests
fcntl-tests
fd-safer-flag
fdopendir
fdopendir-tests
getcwd
getcwd-tests
getdtablesize
getdtablesize-tests
getgroups
getgroups-tests
getpagesize
gettext-h
getugroups
ignore-value
ignore-value-tests
include_next
inline
intprops
lchown
lchown-tests
lstat
lstat-tests
malloc-posix
memchr
memchr-tests
mempcpy
memrchr
memrchr-tests
mgetgroups
mkdir
mkdir-tests
multiarch
open
open-tests
openat
openat-die
openat-tests
pathmax
priv-set
priv-set-tests
progname
realloc-gnu
realloc-gnu-tests
realloc-posix
rmdir
rmdir-tests
same-inode
save-cwd
sleep
sleep-tests
stat
stat-tests
stat-time
stat-time-tests
stdbool
stdbool-tests
stddef
stddef-tests
stdint
stdint-tests
stdio
stdio-tests
stdlib
stdlib-tests
strdup-posix
strerror
strerror-tests
string
string-tests
symlink
symlink-tests
sys_stat
sys_stat-tests
time
time-tests
unistd
unistd-safer
unistd-safer-tests
unistd-tests
unlink
unlink-tests
unlinkdir
usleep
usleep-tests
verify
verify-tests
warn-on-use
wchar
wchar-tests
xalloc
xalloc-die
xalloc-die-tests
xgetcwd
I'll try looking deeper to see where the real culprit lies, and if we
can break the rest of this module chain from dragging in xalloc.
--
Eric Blake ebl...@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
