On 11/14/2010 05:25 PM, Bruno Haible wrote:
Paolo Bonzini wrote:
+# Override grep during configure.
+fn_grep () {

I would suggest more comments.
   - What is the purpose of this override?
   - What are its limitations?
10 years from now, no one will remember.

True, but there is "git blame/git log".

Restrictions are pretty much documented by the code. The only interesting one is the backslash unescaping and the lack of support not only for regex, but also for literal strings containing backslashes.

I'll push a doc fix.

Florin, can you try building GNU sed and see if it has a similar problem?

Thanks,

Paolo

Reply via email to