On 07/30/2010 03:04 PM, Rainer Tammer wrote:
> Hello Bruno,
>
> Bruno Haible wrote:
>> Hello Rainer,
>>
>> Regarding this failure:
>>
>> test-readlink.h:54: assertion failed
>> FAIL: test-readlink
>>
>> Could you please show what is the value of errno between these ASSERT
>> statements:
>>
>> ASSERT (func (BASE "file/", buf, sizeof buf) == -1);
>> printf ("errno = %d\n", errno); perror ("errno was"); /* INSERT THIS LINE
>> */
>> ASSERT (errno == ENOTDIR);
>>
>>
> # ./test-readlink
> errno = 22 (erno.h: #define EINVAL 22 /*
> Invalid argument */)
> errno was: Error 0
> test-readlink.h:55: assertion failed
>
>> Depending on this value, we may want to either change the autoconf test for
>> readlink, or change the test.Is readlink already being replaced due to other bugs? (I guess I need to look more closely at your logs.) If so, then I think the replacement should work around this. If not, I'm perfectly fine relaxing the test (there's already a number of places where we can't guarantee the same errno as required by POSIX without lots of bloat; as long as a reasonable error happens, it's generally okay for a looser test). -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
