On 05/25/2010 02:21 PM, Martin von Gagern wrote: > Hi there! > > I've got gnulib in my repository, so devs don't need a git checkout. > When I last ran the syntax checks from maint.mk, I got a false positive > from prohibit_always-defined_macros complaining about the definition of > environ in build-aux/warn-on-use.h. > > The error is due to the following line in warn-on-use.h > # define environ (*rpl_environ ()) > which conflicts with definitions from unistd.in.h. > > Maybe you should alter that file so it doesn't match the rule. Or you > should explicitely exclude it from the list of files to check.
You can create a per-file exemption list for any syntax-check rule by creating ./.x-sc_name files listing patterns of files to ignore. I believe that recent changes in maint.mk also make it possible for you to add a list of files in cfg.mk that will always be ignored for all syntax rules. While it may be possible to modify gnulib's warn-on-use.h to avoid triggering this false positive in a comment, it is certainly faster for you to exempt various gnulib files from the get-go. > > In my package, wdiff, I've excluded the whole build-aux directory from > that check, but I can easily do so without creating extra files due to > my personal modifications to gnulib. > http://github.com/gagern/gnulib/commit/57646d674f68676ca3b9 > I guess I should try to get my gnulib copyright assignment forms > completed so you can include this upstream as well... We'd welcome the help :) -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
