On 04/06/2010 09:36 AM, Jim Meyering wrote: > FYI, > I noticed unnecessary mktemp simulation in test logs on Solaris 5.11. > This fixes it: > > # First, try to use mktemp. > - d=`env -u TMPDIR mktemp -d -t -p "$destdir_" "$template_" 2>/dev/null` \ > + d=`env -i PATH="$PATH" mktemp -d -t -p "$destdir_" "$template_" > 2>/dev/null` \
Even 'env -i' is risky, since you are removing other possibly-important variables, like POSIXLY_CORRECT. Isn't it better to just do: d=`unset TMPDIR; mktemp -d ...` and bypass env altogether? -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
