According to John W. Eaton on 1/5/2010 1:53 AM: > Although lib/mkdir.c includes xalloc.h, the mkdir module doesn't > depend on xalloc. Should it? If so, how about the following change?
Thanks for the report. mkdir should _not_ depend on xalloc. It is wrong for system call wrappers to call exit(). I'm pushing this, instead. -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net
From 51983dcb2ce9d20eb1f72d0b877e40fe0de07e87 Mon Sep 17 00:00:00 2001
From: Eric Blake <e...@byu.net>
Date: Tue, 5 Jan 2010 06:09:14 -0700
Subject: [PATCH] mkdir: avoid xalloc
Leftovers from when the mkdir replacement was converted to be LGPL.
* lib/mkdir.c (includes): Drop unused header.
Reported by John W. Eaton.
Signed-off-by: Eric Blake <e...@byu.net>
---
ChangeLog | 6 ++++++
lib/mkdir.c | 1 -
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 237fa5c..2e24e7f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-01-05 Eric Blake <e...@byu.net>
+
+ mkdir: avoid xalloc
+ * lib/mkdir.c (includes): Drop unused header.
+ Reported by John W. Eaton.
+
2010-01-04 Jim Meyering <meyer...@redhat.com>
nl_langinfo: avoid configure-time syntax error
diff --git a/lib/mkdir.c b/lib/mkdir.c
index 71437f8..b117b76 100644
--- a/lib/mkdir.c
+++ b/lib/mkdir.c
@@ -29,7 +29,6 @@
#include <string.h>
#include "dirname.h"
-#include "xalloc.h"
/* Disable the definition of mkdir to rpl_mkdir (from the <sys/stat.h>
substitute) in this file. Otherwise, we'd get an endless recursion. */
--
1.6.4.2
signature.asc
Description: OpenPGP digital signature
