-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 12/16/2009 6:17 PM:
> In ANSI C, but not in C99, it is an error to typedef the same type twice:
>   typedef int _gl_warn_on_use;
>   typedef int _gl_warn_on_use;
> 
> Therefore the last line is better changed to 'extern int _gl_warn_on_use'.

OK, I'll make that change.

> 
> Actually one might consider to move the semicolon that terminates the
> declaration into the expansion of _GL_WARN_ON_USE. Then, in the unsupported
> case, the expansion of _GL_WARN_ON_USE(function, message) can be empty.

But then editors like emacs get confused.  Having an explicit semicolon at
the call site rather than embedded in the macro keeps indentation sane.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             e...@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkspipAACgkQ84KuGfSFAYDcSgCeL1c5L9Hu7VSeZwZfyuAjXmNg
lOwAoJO5EFPMw860wioDzGZ3Y0BEwb88
=pztZ
-----END PGP SIGNATURE-----


Reply via email to