-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Bruno Haible on 11/22/2009 9:04 AM:
>> I'd rather make the patch conditional on whether freopen_safer is also in
>> use.
>
> I see. How about this?
A couple of nits, but I'm okay with it.
> --- 238,265 ----
> 0);
> #endif
>
> + {
> #if !_LIBC && defined F_GETFL
> ! int stdout_fd;
> !
> ! # if GNULIB_FREOPEN_SAFER
> ! /* Use of gnulib's freopen-safer module normally ensures that
> ! fileno (stdout) == 1 always. */
Are the two spaces intentional? And mixing "normally" and "always" in the
same sentence makes it sound like you can't make up your mind. How about:
/* Use of gnulib's freopen-safer module guarantees
fileno (stdout) == STDOUT_FILENO. */
> ! stdout_fd = 1;
s/1/STDOUT_FILENO/
- --
Don't work too hard, make some time for fun as well!
Eric Blake [email protected]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAksJYqoACgkQ84KuGfSFAYA60gCeKAYKnY9UvfutMlx4lJq3jW0P
obkAn1oyxlM2EqQKirZd7Elmvk60xYNj
=6oQ+
-----END PGP SIGNATURE-----
