* Alfred M. Szmidt wrote on Sun, Nov 15, 2009 at 06:08:58PM CET:
> > configure.ac:9: version `sharutils_version' doesn't follow Gnits
standards
>
> > Where do you get this error from?
>
> automake. See info Automake Gnits.
>
> I must be missing something utterly obvious,
Line wrapping. :-)
D'oh, why didn't I think of that! Thanks.
> configure.ac:
> | m4_include([version.m4])
> | AC_INIT([GNU sharutils],[sharutils_version],[sharutils_eaddr])
>
> version.m4:
> | m4_define([sharutils_version], [4.7.1])
> | m4_define([sharutils_eaddr], [bug-gnu-ut...@gnu.org])
Oh, that works if you allow m4 traces to see the macro expanded:
AC_INIT([GNU sharutils],sharutils_version,[sharutils_eaddr])
although this is probably safer instead:
AC_INIT([GNU sharutils],m4_defn([sharutils_version]),[sharutils_eaddr])
Ah, that makes sense. Super thanks Ralf!
Bruce, how about this? I'd actually rather see the whole version.m4
mess be removed, but this is a decent fix for now.
2009-11-15 Alfred M. Szmidt <a...@gnu.org>
* configure.ac (AC_INIT): Wrap sharutils_version and
sharutils_eaddr around m4_defn.
(AM_INIT_AUTOMAKE): Added `gnits'.
*** configure.ac.~1.42.~ 2009-11-14 21:11:07.000000000 +0100
--- configure.ac 2009-11-15 18:35:29.480981168 +0100
***************
*** 6,16 ****
dnl FIXME: AC_CHECK_FUNCS([gethostname getwd])
dnl
m4_include([version.m4])
! AC_INIT([GNU sharutils],[sharutils_version],[sharutils_eaddr])
AC_CONFIG_SRCDIR([src/shar.c])
AC_CONFIG_HEADERS([config.h])
! AM_INIT_AUTOMAKE([1.11 dist-bzip2])
AC_USE_SYSTEM_EXTENSIONS
AC_SUBST(DIST_ALPHA)
--- 6,16 ----
dnl FIXME: AC_CHECK_FUNCS([gethostname getwd])
dnl
m4_include([version.m4])
! AC_INIT([GNU
sharutils],m4_defn([sharutils_version]),m4_defn([sharutils_eaddr]))
AC_CONFIG_SRCDIR([src/shar.c])
AC_CONFIG_HEADERS([config.h])
! AM_INIT_AUTOMAKE([1.11 dist-bzip2 gnits])
AC_USE_SYSTEM_EXTENSIONS
AC_SUBST(DIST_ALPHA)
