-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Pádraig Brady on 9/7/2009 6:32 PM:
>>> "fstatat.c", line 39: undefined symbol: AT_SYMLINK_NOFOLLOW
>> Hmm. That should be taken care of by the gnulib <fcntl.h> replacement.
>> Are we missing a #include? Can you post the full failure?
>
> gnulib 52c658e seems to have removed #include "openat.h" from fstatat.c
> but not replaced it with #include <fcntl.h>
Yep; and only Solaris had the problem, because that is the only platform
with broken fstatat (the other platforms either lack it or it works
entirely). Fixed as follows; coreutils needs to update the gnulib submodule.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqlwIgACgkQ84KuGfSFAYCYWQCbBC7k9nNOQ7kWrZb97lGz/Tpw
ADkAniQxA4kKKzEv7vognH3MDcKFRpGV
=nQmf
-----END PGP SIGNATURE-----
From 2c90f1af0fd6fcf444f5c16de9ff465651a854fc Mon Sep 17 00:00:00 2001
From: Eric Blake <e...@byu.net>
Date: Mon, 7 Sep 2009 20:16:00 -0600
Subject: [PATCH] fstatat: fix compilation on Solaris
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* lib/fstatat.c (includes): Add fcntl.h.
Reported by Pádraig Brady.
Signed-off-by: Eric Blake <e...@byu.net>
---
ChangeLog | 6 ++++++
lib/fstatat.c | 1 +
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 0b9e3a0..7df9226 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-09-08 Eric Blake <e...@byu.net>
+
+ fstatat: fix compilation on Solaris
+ * lib/fstatat.c (includes): Add fcntl.h.
+ Reported by Pádraig Brady.
+
2009-09-07 Eric Blake <e...@byu.net>
rename: modernize replacement
diff --git a/lib/fstatat.c b/lib/fstatat.c
index 2bf547e..9b0c1af 100644
--- a/lib/fstatat.c
+++ b/lib/fstatat.c
@@ -22,6 +22,7 @@
#include <sys/stat.h>
#include <errno.h>
+#include <fcntl.h>
#include <string.h>
#undef fstatat
--
1.6.3.3.334.g916e1
