-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Jim Meyering on 9/6/2009 11:49 PM: >> + openat: with no lchmod, only fail lchmodat on symlinks >> + * lib/fchmodat.c (lchmod) [!HAVE_LCHMOD]: Perform lstat first, to >> + minimize failure cases. > > Is this useful to you on Cygwin? Fewer diagnostics?
Not for cygwin, since it has lchmod. > The drawback is that it makes it harder > to perform a run-time test for lchmod support. > The test requires a symlink. OK, I see your point. Failing with ENOSYS regardless of whether we _could_ have passed makes it obvious that there is no lchmod ability, and the user has to fall back to chmodat themselves if they know they aren't working on a symlink. Patch withdrawn (unless anyone else can speak up for a reason of why to include it). - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkqk6k8ACgkQ84KuGfSFAYDpygCePpG8//cW0CiI64q2zryCaC5R GqsAnjvcO8c2JisE4cHqpo6MlPHYHenw =zSe+ -----END PGP SIGNATURE-----
