Bruno Haible wrote:

> Jim Meyering wrote:
>> Consider consistency with automake-generated rules.
>> For example, I see these uses of $(MKDIR_P) in coreutils/lib/Makefile:
>> ...
>> I think anyone wanting to use some other MKDIR_P value
>> would be surprised (and report it as a bug) to have to
>> resort to rerunning configure or config.status
>
> OK, go ahead and make the substitution.
>
> I can see that in rare, rare cases, since MKDIR_P is a command, people
> may want to use different versions of it. But for things like @LIBINTL@
> and @LIBSOCKET@, it is still better to write them as @LIBINTL@, not 
> $(LIBINTL),
> because if the corresponding autoconf macro was not run, it makes the error
> appear on all platforms. Otherwise it's too easy to write a Makefile.am
> that builds fine on glibc systems but not on Solaris or MacOS X.

Ok.  Thanks.

I was about do it with this command:

    perl -pi -e 's/\...@mkdir_p\@/\$(MKDIR_P)/' $(g grep -l '@MKDIR_P@' modules)

With that, the only remaining use is here:

    build-aux/po/Makefile.in.in:MKDIR_P = @MKDIR_P@

I'll refrain from modifying it, since it comes from gettext.

Then I remembered that this started with a patch from Simon.
So I'll let Simon push his patch.


Reply via email to