FYI, there was a useless initialization in canonicalize_filename_mode. [spotted by using clang: http://clang.llvm.org/StaticAnalysis.html] This removes it:
>From 08999eb3be233d8c54c9fe00c5c263247265e897 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@redhat.com> Date: Mon, 31 Aug 2009 16:32:40 +0200 Subject: [PATCH] canonicalize: remove useless initialization * lib/canonicalize.c (canonicalize_filename_mode): Remove useless initialization of local, "end". --- ChangeLog | 6 ++++++ lib/canonicalize.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7dee308..4883188 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2009-08-31 Jim Meyering <meyer...@redhat.com> + + canonicalize: remove useless initialization + * lib/canonicalize.c (canonicalize_filename_mode): Remove useless + initialization of local, "end". + 2009-08-30 Bruno Haible <br...@clisp.org> Fix an unnecessary error on Solaris 10 on NFSv3 file systems. diff --git a/lib/canonicalize.c b/lib/canonicalize.c index 4f34839..3744654 100644 --- a/lib/canonicalize.c +++ b/lib/canonicalize.c @@ -1,5 +1,5 @@ /* Return the canonical absolute name of a given file. - Copyright (C) 1996-2008 Free Software Foundation, Inc. + Copyright (C) 1996-2009 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -199,7 +199,7 @@ canonicalize_filename_mode (const char *name, canonicalize_mode_t can_mode) dest = rname + 1; } - for (start = end = name; *start; start = end) + for (start = name; *start; start = end) { /* Skip sequence of multiple file name separators. */ while (*start == '/') -- 1.6.4.2.363.g2d6e