Hi Bruno, On Sun, Aug 2, 2009 at 5:01 AM, Bruno Haible<br...@clisp.org> wrote: > Sam Steingold wrote: >> alas, there is still some duplication between >> modules/regexp/glm4 and src/glm4, specifically: >> codeset.m4 >> locale-fr.m4 >> locale-ja.m4 >> locale-zh.m4 >> mbrtowc.m4 >> mbstate_t.m4 >> unistd_h.m4 > > Duplication between .m4 files is harmless.
but _extremely_ unaesthetic. there should be a way around. the best way, IMO, is to enable a _shared_ glm4 between src, regexp and wildcard. >> and between modules/regexp/gllib and src/gllib, specifically: >> unistd.in.h > > You should be able to fix this by adding 'unistd' to your GNULIB_CORE > variable. thanks, it worked. >> also, build-dir/gllib no longer builds: >> >> $ make gllib >> mkdir -p gllib >> if test ! -f gllib/Makefile; then sh config.status gllib/Makefile depfiles; >> fi >> config.status: creating gllib/Makefile >> config.status: executing depfiles commands >> cd gllib && make CFLAGS="-W -Wswitch -Wcomment -Wpointer-arith -Wimplicit >> -Wreturn-type -Wmissing-declarations -Wno-sign-compare >> -Wno-format-nonliteral -O2 -fexpensive-optimizations -falign-functions=4 >> -DUNICODE -DDYNAMIC_FFI -I. " >> make[1]: Entering directory `/home/sds/src/clisp/current/build-O/gllib' >> ... >> rm -f string.h-t string.h >> { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */' && \ >> sed -e 's|@''INCLUDE_NEXT''@|include_next|g' \ >> -e 's|@''PRAGMA_SYSTEM_HEADER''@|#pragma GCC system_header|g' \ >> -e 's|@''NEXT_STRING_H''@||g' \ >> -e 's|@''GNULIB_MBSLEN''@||g' \ >> -e 's|@''GNULIB_MBSNLEN''@||g' \ >> ... >> ./string.h:27:15: error: #include_next expects "FILENAME" or <FILENAME> >> ./string.h:54:5: error: #if with no expression > > The 'string' module occurs as dependency of the 'memchr' module or 'mbsrtowcs' > modules. Somehow a bunch of AC_SUBSTed variables (such as NEXT_STRING_H) > are not correctly substituted. You should verify that > 1) gllib/Makefile.in contains the line > NEXT_STRING_H = @NEXT_STRING_H@ nope: $ grep NEXT_STRING_H src/gllib/Makefile.in -e 's|@''NEXT_STRING_H''@|$(NEXT_STRING_H)|g' \ > 2) config.status contains the line > S["NEXT_STRING_H"]="<string.h>" nope, does not contain NEXT_STRING_H at all. > 3) configure contains the lines > NEXT_STRING_H > and > NEXT_STRING_H=$gl_cv_next_string_h nope, no NEXT_STRING_H either. > If 1) is not fulfilled, you should look at the automake invocation that > you issued after the autoconf invocation after the gnulib-tool invocations. $ make -f Makefile.devel src/gllib/Makefile.in cd src/gllib && cd .. && automake gllib/Makefile $ no diagnostics. > If 3) is not fulfilled, it's time to look at your autoconf and m4 versions. autoconf (GNU Autoconf) 2.63 m4 (GNU M4) 1.4.11 > If 2) is not fulfilled but 3) is, what are your versions of sh (bash?) and > awk (gawk)? GNU Awk 3.1.6 GNU bash, version 3.2.48(1)-release -- Sam Steingold <http://sds.podval.org>