Hi Bruno, * Bruno Haible wrote on Sat, Mar 14, 2009 at 04:51:46PM CET: > > * gnulib-tool: Default $MAKE to 'make'. > > (func_create_testdir, func_create_megatestdir): Use $MAKE rather > > than make. Initialize $MAKE in the do-autobuild script. > > * top/maint.mk (init-coverage, build-coverage): Use $(MAKE) > > rather than make. > > This is fine. But it should be committed in 3 separate commits, since it's 3 > logically independent things:
Right. > - gnulib-tool lines 4200..4270: this modifies the files that are generated > by gnulib-tool. $MAKE can be set on the target machine. > - the rest of the gnulib-tool patch: this changes the commands invoked > by gnulib-tool. > - top/maint.mk. Btw, why does this use $(MAKE) and not $(MAKE) $(MAKEFLAGS)? I assume you meant $(MAKE) $(AM_MAKEFLAGS). Omission on my side, fixed in the commit. (One should not add $(MAKEFLAGS) to a rule, that breaks various things as this variable is private to some make implementations and can contain stuff not suitable as option flags without munging.) Thanks for the quick review! Pushed. Cheers, Ralf
