Hello Bruno, thanks for review!
On Friday 27 of February 2009 17:02:56 Bruno Haible wrote: > As I understand it, the patch does not fix two things that were mentioned > negatively by Sven: > - that hidden files appear at the end, rather than at the beginning, Well, I don't know which order is "correct". We can treat hidden files specially and force them to move up, ok? > - that "a~" precedes "a". Sounds ok to me. Sorting by version means older (backed up) version is before the newer version. > Also, in the patch, the variable 'read_dot' is confusing. Should it not > be called 'read_nondot'? read_alpha and read_dot are state variables. If read_alpha is true, it means "Now read alpha!". If read_dot is true, it means "Now read dot!". If it is confusing, another naming is wellcome. In that case these two names should be consistent I think. > Should I commit your patch nevertheless? No. There should be an consensus on the list first. Kamil
