On Sat, 2009-02-21 at 11:42 +0100, Bruno Haible wrote: > Hi David, > > > Attached is an incremental patch with those changes. > > Thanks. With the confirmation by Karl that the copyright is assigned to the > FSF > both for Dan Berrange and for you, I've added your module, in two commits: > > > 2009-02-21 David Lutterkort <lut...@redhat.com> > > Tests for module 'safe-alloc'. > * tests/test-safe-alloc.c: New file. > * modules/safe-alloc-tests: New file. > > New module 'safe-alloc'. > * lib/safe-alloc.h: New file. > * lib/safe-alloc.c: New file. > * m4/safe-alloc.m4: New file. > * modules/safe-alloc: New file. > * doc/safe-alloc.texi: New file. > * doc/gnulib.texi: Include it. > * MODULES.html.sh (Memory management functions <stdlib.h>): Add > safe-alloc. > > > Reviewing this in detail, I propose a bit of cosmetics: > - In the doc: Include the new section near the beginning; the end of that > chapter deals with build infrastructure. Also use two spaces after a > sentence terminator. When you terminate a sentence on one line and start > a new one in the next line, 'makeinfo' inserts two spaces after the > period. For consistency, it's best to do the same also for all other > sentence breaks. > - I did not understand the sentence "use calloc in favor of malloc", so > I reworded that. > - In safe-alloc.h and the tests: In gnulib we have the habit of including > the header containing the specification first, right after config.h. > This helps verifying that the header is self-contained, i.e. that it > includes <stddef.h>, <stdlib.h> or whatever is necessary to define the > types that it needs. > > OK to commit that?
Yes, absolutely. Thanks for touching up the docs - they are definitely more readable now ! David
