Hi Jim, > Once you've adjusted your patch to do the same for the > new return path it adds, you're welcome to commit it.
Done. > *ENDPTR is no longer guaranteed to be set. Whee, well spotted. I missed this most probably because there was no documentation nearby that would have reminded me of the full contract of this function. So here is a proposed documentation, more detailed than the one in doc/c-strtod.texi. 2009-01-23 Bruno Haible <br...@clisp.org> * lib/c-strtod.h (c_strtod, c_strtold): Add specification. --- lib/c-strtod.h.orig 2009-01-24 00:08:16.000000000 +0100 +++ lib/c-strtod.h 2009-01-24 00:07:51.000000000 +0100 @@ -1,2 +1,33 @@ -double c_strtod (char const *, char **); -long double c_strtold (char const *, char **); +/* Convert string to double, using the C locale. + + Copyright (C) 2003-2004, 2009 Free Software Foundation, Inc. + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +/* Parse the initial portion of the string pointed to by NPTR as a floating- + point number (in decimal or hexadecimal notation), like in the C locale: + accepting only the ASCII digits '0'..'9', and only '.' as decimal point + character.. + If ENDPTR is not NULL, set *ENDPTR to point to the first byte beyond the + parsed number or to NPTR if the string does not start with a parseable + number. + If successful, return the value as a double or 'long double', respectively, + and don't modify errno. In case of overflow, return ±HUGE_VAL or + ±HUGE_VALL, respectively, and set errno to ERANGE. In case of underflow, + return a value very near to 0 and set errno to ERANGE. If the string + does not start with the a number at all, return 0 (and recall that if + ENDPTR != NULL, *ENDPTR is set to NPTR). In case of other error, return 0 + and set errno, for example to EINVAL or ENOMEM. */ +extern double c_strtod (char const *nptr, char **endptr); +extern long double c_strtold (char const *nptr, char **endptr);