Re: parse-duration tweaks

[Bruno Haible]

Bruce Korb wrote:
> > Also, can you clarify the purpose of having the
> >   fprintf (stderr, _("Invalid time duration:  %s\n"), pz);
> > ...
> 
> Makes sense.  Zap it.  :)

OK, I applied the patch with the following modification:


--- lib/parse-duration.c.orig   2008-12-17 00:00:17.000000000 +0100
+++ lib/parse-duration.c        2008-12-16 23:58:28.000000000 +0100
@@ -28,10 +28,6 @@
 #include <string.h>
 #include "xalloc.h"
 
-#ifndef _
-#define _(_s)  _s
-#endif
-
 #ifndef NUL
 #define NUL '\0'
 #endif
@@ -571,7 +567,6 @@
 parse_duration (char const * pz)
 {
   time_t res = 0;
-  int saved_errno;
 
   while (isspace ((unsigned char)*pz))
     pz++;
@@ -602,9 +597,6 @@
 
   } while (0);
 
-  saved_errno = errno;
-  fprintf (stderr, _("Invalid time duration:  %s\n"), pz);
-  errno = saved_errno;
   return BAD_TIME;
 }