Reuben Thomas <[EMAIL PROTECTED]> wrote:
...
> openat-die.c:31: warning: no previous prototype for ‘openat_save_fail’
> openat-die.c:44: warning: no previous prototype for ‘openat_restore_fail’
> open-safer.c: In function ‘open_safer’:
> open-safer.c:43: warning: signed and unsigned type in conditional expression
Thanks for the report.
I've just addressed the first one above with this:
[after confirming that openat.h is already listed in modules/openat-die]
>From c590a4c86428649863b9b82be386aaaa747586e0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <[EMAIL PROTECTED]>
Date: Thu, 16 Oct 2008 14:35:41 +0200
Subject: [PATCH] openat-die.c: avoid 'no previous prototype' warning
* lib/openat-die.c: Include "openat.h".
Reported by Reuben Thomas <[EMAIL PROTECTED]>.
---
ChangeLog | 6 ++++++
lib/openat-die.c | 4 +++-
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 8d470e8..0394202 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-10-16 Jim Meyering <[EMAIL PROTECTED]>
+
+ openat-die.c: avoid 'no previous prototype' warning
+ * lib/openat-die.c: Include "openat.h".
+ Reported by Reuben Thomas <[EMAIL PROTECTED]>.
+
2008-10-16 Simon Josefsson <[EMAIL PROTECTED]>
* m4/netdb_h.m4: Assume that if netdb.h exists, it works.
diff --git a/lib/openat-die.c b/lib/openat-die.c
index 6bc533d..77da06e 100644
--- a/lib/openat-die.c
+++ b/lib/openat-die.c
@@ -1,6 +1,6 @@
/* Report a save- or restore-cwd failure in our openat replacement and then
exit.
- Copyright (C) 2005, 2006 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006, 2008 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -17,6 +17,8 @@
#include <config.h>
+#include "openat.h"
+
#include <stdlib.h>
#include "error.h"
--
1.6.0.2.98.gc82e
