Bruno Haible wrote: >> AC_DEFUN([gl_FUNC_CLOSE], >> [ >> ! m4_ifdef([gl_PREREQ_SYS_H_WINSOCK2], [ >> ! gl_PREREQ_SYS_H_WINSOCK2 >> ! if test $UNISTD_H_HAVE_WINSOCK2_H = 1; then >> ! gl_REPLACE_CLOSE >> ! fi >> ! ]) >> ]) > > I'm not so happy with this code. If we create a tests directory where > the 'close' module is part of lib/ and 'sys_socket' is part of tests/, > the code in lib/ will be compiled in a way that does not invoke the > _gl_close_fd_maybe_socket function in tests/.
So that would mean that there would be problems if anything that requires sys_socket in the tests would not require it in the library module. Considering that the only test module requiring sys_socket right now is poll-tests, and it is actually just for clarity because poll requires sys_socket too (via sys_select), I think we can live with it. Paolo
