Le mardi 16 septembre 2008 à 10:28 +0200, Paolo Bonzini a écrit : > Yoann Vandoorselaere wrote: > > Le lundi 15 septembre 2008 à 21:21 +0200, Paolo Bonzini a écrit : > >>> The poll-tests module that is now available in the GnuLib repository > >>> currently fail on OpenBSD: > >>> > >>> Unconnected socket test... failed (huh, connect succeeded?) > >>> Connected sockets test... failed (huh, connect succeeded?) > >> Uhm, this means O_NONBLOCK sockets do not work there? > > > > To me, this rather look like a bug in connect_to_socket(), which assume > > that connecting a non blocking socket should never succeed on first try. > > Where does this assumption come from? > > From the fact that the socket is listening, but not accepting yet. I > added the check mostly to see how Winsock behaved, but yes, it can be > relaxed for OpenBSD. I pushed the following patch:
This solved the 'unconnected socket test': Unconnected socket test... passed Connected sockets test... failed (expecting POLLHUP after shutdown) General socket test with fork... failed (expecting POLLHUP after shutdown) [...] > I suppose you don't have similar build bots for Windows, do you? Not yet, hopefully soon.. -- Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies Tel: +33 (0)8 70 70 21 58 Fax: +33(0)4 78 42 21 58 http://www.prelude-ids.com
