Bruno Haible <[EMAIL PROTECTED]> wrote: > Hi Jim (and Paul, if you are still listening), > > I'm starting to fix the 6 portability problems of the 'acl' module. > > First of all, since there will be more ifdefs > - to distinguish some of the Linux, FreeBSD, MacOS X, IRIX, Tru64, Cygwin > platforms which have a POSIX like API, > - to add support for 4 other APIs (Solaris, HP-UX, AIX, older AIX), > > I propose to move copy_acl() to a file of its own. Simply to make the > basic acl.c easier to read and understand. > > OK to commit? > > 2008-05-22 Bruno Haible <[EMAIL PROTECTED]> > > Split off copy_acl function to separate file. > * lib/copy-acl.c: New file, extracted from lib/acl.c. > * lib/acl.c (copy_acl): Moved function to separate file. > * m4/acl.m4 (gl_FUNC_ACL): Remove unconditional AC_LIBOBJs. > * modules/acl (Files): Add lib/copy-acl.c. > (Makefiles.am): Augment lib_SOURCES.
So far so good. Please do. Though, for future patches to my attention please use git format-patch, since that makes it easier for me to apply and ensure that when I review (and vc-add on a temporary branch) I add new files, get permissions right, etc. I like that it produces unidiffs, too.
