-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Bruno Haible on 8/18/2007 1:25 PM: > Eric Blake wrote: >>> + translated_pattern = nl_langinfo (nl_index); >> Not reliable. nl_langinfo is entitled to use static storage that can be >> overwritten by later calls to nl_langinfo or by subsequent changes to the >> locale. You will need to do something like strdup to avoid problems with >> nl_langinfo's storage; then properly clean up to avoid memory leaks. > > Oh, indeed. How about this? > > 2007-08-18 Bruno Haible <[EMAIL PROTECTED]> > > * lib/rpmatch.c: Include langinfo.h. > (N_): New macro. > (try): Copy the pattern into safe memory before caching it. > (localized_pattern): New function/macro. > (rpmatch): Use it. Add translator comments. > * m4/rpmatch.m4 (gl_PREREQ_RPMATCH): Test for nl_langinfo and YESEXPR. > Suggested by Eric Blake.
Looks good to me. Go ahead and install it. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGx07t84KuGfSFAYARAuY4AJ9SjzQUj2Stn4cAAGN/mDqMgmM7CQCeLLmm z16dbjoEW1SM8f1eoAdZzHk= =9zyV -----END PGP SIGNATURE-----